Add docs for the Mime component #10886
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pborreli
reviewed
Jan 15, 2019
Pierstoval
suggested changes
Jan 15, 2019
Pierstoval
reviewed
Jan 15, 2019
Pierstoval
reviewed
Jan 15, 2019
fabpot
force-pushed
the
mime-component-docs
branch
from
913d8cf to
9c818ad
Compare
fabpot
force-pushed
the
mime-component-docs
branch
3 times, most recently
from
def17b7 to
97e2b48
Compare
fabpot
force-pushed
the
mime-component-docs
branch
from
97e2b48 to
bd25312
Compare
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jan 17, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes #29896). Discussion ---------- [Mime] Add the component | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #28832 #21985 makes #15460 trivial | License | MIT | Doc PR | symfony/symfony-docs#10886 This has been on my todo-list for X years :) Commits ------- bdca5d9 tweaked code 5268389 [Mime] added freedesktop as a source for mime types 74ca91d [Mime] added the component d7ee0ec [HttpFoundation] updated File code
Instead of adding comments about possible changes, I've decided to commit them. Revert totally or partially if you disagree with them. Thanks!
OskarStark
approved these changes
Jan 18, 2019
tony-tran
reviewed
Jan 19, 2019
| **Purpose**: Add a custom MIME type guesser to MimeTypes | ||
|
|
||
| To add a custom MIME type guesser - in addition to the core guessers - create a | ||
| class that implements :class:`Symfony\\Component\\Mime\\MimeTypes`, register it |
There was a problem hiding this comment.
Is it MimeTypesInterface ?
| ================== | ||
|
|
||
| The MIME component provides utilities related to MIME types, such as | ||
| guessing the MIME type of a given file. |
There was a problem hiding this comment.
If the scope of the component is just media types rather than MIME as a whole, could it be named as such instead?
|
Looks like the code was merged, can we merge this too and announce this new component? |
|
Closing because we've added all these contents to #11280, which documents the entire Mime component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs for symfony/symfony#29896